fix: parse rm flags correctly to avoid pathname false positives#30
Open
lunareed720 wants to merge 1 commit into
Open
fix: parse rm flags correctly to avoid pathname false positives#30lunareed720 wants to merge 1 commit into
lunareed720 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
Problem
The
pre_tool_use.pyhook sometimes blocks safermcommands because it regex-matches-...r...inside pathnames (e.g.soft-hold-enrollment) as if it were anrm -rflag.Fix
shlex.split()and interpret-r/-R/--recursiveand-f/--forceonly when they are actual option tokens.-ris present (/,.,..,~, wildcards).rmwith both recursive+force remains blocked.Test
Added a small
unittestfile undertests/that reproduces the reported false positive and covers a few core cases.Run locally:
python3 -m unittest discover -s tests -p 'test_*.py'