Save+share using public ids instead of tokens by nofurtherinformation · Pull Request #415 · districtr/districtr-v2

nofurtherinformation · 2025-07-07T17:54:28Z

This PR refactors save/share functionality to incorporate a public sequential ID (accessed when a map is moved off of 'scratch work' or shared with a frozen link. Additionally, it moves toward sharing in one of the three forms:
-map/{public id} - Read only public map
-map/edit/{document id} - Editable map
-map/{public id}?pw=true - Password required share link

Reviewers

Primary: @raphaellaude
Secondary:

Checklist

Creating a map takes you to /map/edit/foo
Sharing a link frozen yields /map/{public id}
Sharing a link with password yields /map/{public id}?pw=true
Password unlocking a pw link redirects to the edit ID
Public maps can be copied
In-use (locked/checked out maps can be copied)
Thumbnails generate from the edit ID and generate to the public ID

Screenshots (if applicable):

nofurtherinformation · 2025-08-05T02:29:29Z

I think this is ready for review. Some key updates:

The assignment reload on tab focus is now resolved; tanstack had a behavior to auto re-fetch on focus which caused the behavior and has been flagged to not refetch unless we do it manually
The refocus UX has been further cleaned up with some additional logic to prevent flashing of progress indicators
Tab refocus rendering has some specific handling for the case where the browser tab goes to sleep and loses GL context for some weird reason; the app does a check to see if maplibre state is correct and if not do a full re-render
Metadata now comes from the mapDocument rather than userMaps, which caused public views to not have the correct metadata
Custom cursor icons are fixed, this was a filepath issue
I removed the publish requirement for now. I think this leads to some tricky edge cases and may not ultimately be better UX
Thumbnails on the preview are being fussy, but I think this is just an environment issue uploading to the wrong s3 bucket
Added better error text when going to a document that doesn't exist
Contiguity and unassigned endpoints now use the public ID

raphaellaude

Looking good. A few comments:

H: Why make documents accessible publicly if they aren't ready to share?
H: I'm getting invalid password on checkout. We should add the tests back in to make sure this endpoint works
Saving the password collapses the text field and the share type goes back to frozen, so you have to click copy link while the PW dialog is open.

After getting the 404 doc not found error (which looks great!) we should probably route the user back to the blank map rather than leave them hanging on the /edit/ page

raphaellaude · 2025-08-05T09:13:28Z

-        stmt = stmt.where(Document.public_id == document_id.value).where(
-            text("map_metadata->>'draft_status' = 'ready_to_share'")
-        )
+        stmt = stmt.where(Document.public_id == document_id.value)


H: why remove this? do we want all maps to be publicly accessible before they are ready to share?

I think the case of someone sharing the map while not finished is more likely than the case of someone exploring random numbers and happening across an unfinished plan

but not 100% sure if this is the desired functionality

nofurtherinformation · 2025-08-05T12:20:09Z

H: I'm getting invalid password on checkout. We should add the tests back in to make sure this endpoint works

Chris and I experienced this, too. I'll take a look today and see what's going on!

nofurtherinformation · 2025-08-05T12:20:40Z

Good catches on the PW field collapsing and redirect -- I'll update those today

nofurtherinformation · 2025-08-05T14:49:21Z

redirect

Resolved in ca3b963

PW field collapsing

Resolved in 5f1cbad

invalid password on checkout

I believe this is resolved in 0dd4c9e but we should add some more testing

raphaellaude

Lgtm! Nice work

raphaellaude · 2025-08-06T08:30:40Z

Lgtm! Nice work

going to merge to unblock some downstream work

- mapStore.ts: initialLoadingState only checked the district route prefix, a leftover from before community mode existed (PR #415, pre-COI) that never got extended when COI shipped. COI page loads started INITIALIZING instead of LOADING, so setMapRef could mark the app LOADED before the real document ever arrived. - pageMetadataUtils.ts: generateMapPageMetadata read the document id from searchParams, but every id-bearing map/coi route now (post URL-flip) carries it as a path param instead — so district map/edit /eval pages were silently generating generic OG metadata (broken "Map not found" preview image) instead of the map's own name/ description/thumbnail. Now reads params.public_id first, falling back to searchParams.document_id only for the legacy /map?document_id= redirect landing page. Dropped the COI pages' now-redundant manual searchParams repackaging now that direct assignment works for them too.

nofurtherinformation added 7 commits July 7, 2025 09:02

backend wip

d797b47

tests update

c2f0d31

retrofit public endpoints with public ID

c4d317f

fix public id locaiton

b4d7fce

clean up migrations

41a3e3f

big refactor away from jwt for sharing

4869fb2

TEMP disable tests

9f64802

nofurtherinformation temporarily deployed to pr-415 July 7, 2025 17:54 — with GitHub Actions Inactive

nofurtherinformation self-assigned this Jul 7, 2025

nofurtherinformation added 3 commits July 23, 2025 16:18

Merge branch 'main' into save-share-public-ids

ef103a8

Move public ID to token table and backfill

c5827c4

clean up

7b1616e

nofurtherinformation had a problem deploying to pr-415 July 23, 2025 21:38 — with GitHub Actions Failure

remove unneeded public methods

c0ebc3f

nofurtherinformation had a problem deploying to pr-415 July 23, 2025 21:41 — with GitHub Actions Failure

Clean up and fixes

a4abb3e

nofurtherinformation had a problem deploying to pr-415 July 23, 2025 21:59 — with GitHub Actions Failure

clean up assignments

b361440

nofurtherinformation had a problem deploying to pr-415 July 23, 2025 22:01 — with GitHub Actions Failure

clean up

23e34a8

nofurtherinformation had a problem deploying to pr-415 July 23, 2025 22:15 — with GitHub Actions Failure

WIP

a1cd48c

nofurtherinformation temporarily deployed to pr-415 July 23, 2025 22:15 — with GitHub Actions Inactive

nofurtherinformation added 2 commits July 23, 2025 17:41

clean up depedency args

1b27afc

refactor back to share endpoint

b1987a7

nofurtherinformation temporarily deployed to pr-415 July 23, 2025 22:41 — with GitHub Actions Inactive

mergeroni

90a40c5

raphaellaude temporarily deployed to pr-415 July 24, 2025 14:35 — with GitHub Actions Inactive

nofurtherinformation added 2 commits July 24, 2025 14:26

clean up metadata

000d80f

Clean up routes

87c4519

nofurtherinformation had a problem deploying to pr-415 August 4, 2025 20:35 — with GitHub Actions Error

Remove refetch on focus

213560a

nofurtherinformation temporarily deployed to pr-415 August 4, 2025 20:36 — with GitHub Actions Inactive

cleanup shade

20a95db

nofurtherinformation temporarily deployed to pr-415 August 4, 2025 20:42 — with GitHub Actions Inactive

nofurtherinformation marked this pull request as ready for review August 5, 2025 02:22

Update useMapBrowserEvents.tsx

2f45364

nofurtherinformation temporarily deployed to pr-415 August 5, 2025 02:52 — with GitHub Actions Inactive

raphaellaude requested changes Aug 5, 2025

View reviewed changes

added tests

1cf661d

but not 100% sure if this is the desired functionality

raphaellaude temporarily deployed to pr-415 August 5, 2025 10:38 — with GitHub Actions Inactive

nofurtherinformation added 3 commits August 5, 2025 09:21

Redirect on failed get document

ca3b963

Handle password business logic in state

0dd4c9e

Only reset state on mapdocument change

5f1cbad

nofurtherinformation temporarily deployed to pr-415 August 5, 2025 14:45 — with GitHub Actions Inactive

nofurtherinformation requested a review from raphaellaude August 5, 2025 19:23

fix toolbar not conditionally loading

4c1ac96

nofurtherinformation temporarily deployed to pr-415 August 6, 2025 00:08 — with GitHub Actions Inactive

Merge branch 'main' into save-share-public-ids

c9f2272

nofurtherinformation temporarily deployed to pr-415 August 6, 2025 00:42 — with GitHub Actions Inactive

raphaellaude approved these changes Aug 6, 2025

View reviewed changes

raphaellaude merged commit caf8806 into main Aug 6, 2025
2 checks passed

raphaellaude deleted the save-share-public-ids branch August 6, 2025 08:30

raphaellaude deployed to pr-415 August 6, 2025 08:30 — with GitHub Actions Active

Navigation Menu

Uh oh!

Save+share using public ids instead of tokens - #415

Save+share using public ids instead of tokens#415
raphaellaude merged 81 commits into
mainfrom
save-share-public-ids

nofurtherinformation commented Jul 7, 2025 •

edited

Loading

Uh oh!

nofurtherinformation commented Aug 5, 2025 •

edited

Loading

Uh oh!

raphaellaude left a comment

Uh oh!

raphaellaude Aug 5, 2025

Uh oh!

nofurtherinformation Aug 5, 2025

Uh oh!

nofurtherinformation commented Aug 5, 2025

Uh oh!

nofurtherinformation commented Aug 5, 2025

Uh oh!

nofurtherinformation commented Aug 5, 2025

Uh oh!

raphaellaude left a comment

Uh oh!

raphaellaude commented Aug 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nofurtherinformation commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewers

Checklist

Screenshots (if applicable):

Uh oh!

nofurtherinformation commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raphaellaude left a comment

Choose a reason for hiding this comment

Uh oh!

raphaellaude Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

nofurtherinformation Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

nofurtherinformation commented Aug 5, 2025

Uh oh!

nofurtherinformation commented Aug 5, 2025

Uh oh!

nofurtherinformation commented Aug 5, 2025

Uh oh!

raphaellaude left a comment

Choose a reason for hiding this comment

Uh oh!

raphaellaude commented Aug 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nofurtherinformation commented Jul 7, 2025 •

edited

Loading

nofurtherinformation commented Aug 5, 2025 •

edited

Loading