District and Location Comments

[nofurtherinformation]

Adds metadata fields for per-district comments and location based comments

Description

• Comment on specific districts
• Cleans up public view

Reviewers

• Primary: @mariogiampieri
• Secondary:

Checklist

• Update FE and BE schemas/types
• UI to add comments
• UI to view comments

[raphaellaude]

schema thoughts! PS. any reason you're merging into public ids rather than main?

[raphaellaude]

H: let's please please please not expand the scope of this json blob

[raphaellaude]

This is a good opportunity to refactor. Things like tags and comments definitely make sense as their own tables IMO

[nofurtherinformation]

I know this is not a great pattern and pretty inelegant, but it would strictly work as is.

I am with you longer term, but this feature is a moderately strong nice to have for this week. I don't think total capacity is there to do the refactor this week.

Do you have any concerns to this addition to the metadata?

[nofurtherinformation]

any reason you're merging into public ids rather than main?

2 things -- I wanted to avoid alembic shenanigans swapping between branches when possible, and the way metadata loads to the FE changes slightly with Public IDs to be on the map document instead of in user maps so I wanted to follow that pattern

[nofurtherinformation]

2 things -- I wanted to avoid alembic shenanigans swapping between branches when possible...

P.s. I figured this would merge into main after public IDs so we can just swap the merge target!