Skip to content

Map galleries component - #429

Merged
nofurtherinformation merged 97 commits into
mainfrom
map-galleries
Aug 21, 2025
Merged

Map galleries component#429
nofurtherinformation merged 97 commits into
mainfrom
map-galleries

Conversation

@nofurtherinformation

@nofurtherinformation nofurtherinformation commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator

#104

Description

  • Adds a more ergonomic backend to query a list of plans/map documents
  • Adds a FE component
  • Adds CMS bindings for the component
  • This component will NOT ssr

Reviewers

Checklist

  • Add /api/documents/list endpoint
  • List endpoint can query based on given IDs or given tags
  • List endpoint is paginated
  • Test list endpoint
  • Component for map gallery
  • CMS bindings for map gallery component
  • FE rendering for map gallery component

Screenshots (if applicable):

Tag/place page:
Screenshot 2025-08-05 at 1 32 22 PM

CMS editor:
Screenshot 2025-08-05 at 1 32 38 PM

@mariogiampieri

Copy link
Copy Markdown
Collaborator

Q/I: Wondering if it's a Fly issue but I get 403s for each of the thumbnails that are loaded:

image

It looks like there's supposed to be a fallback image in cases where images aren't available or don't load based on the screenshot above.

@mariogiampieri

Copy link
Copy Markdown
Collaborator

H: The gallery component has a blinking cursor when the user clicks into it. It appears the user can edit the gallery content inline, but the update content button doesn't activate and pressing delete removes the entire gallery. The gallery should only be editable via the gear icon and not inline in the wyswig editor or the form should be more robust.

@nofurtherinformation

Copy link
Copy Markdown
Collaborator Author

Ty @mariogiampieri ! I've fixed the issue with the fallback image (in the future, we need to set up a CRON job to generate thumbnails). We'll want a future PR with some CMS fixes

Comment thread backend/app/main.py

@mariogiampieri mariogiampieri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback image works fine now and understand re: having a CMS-focused PR in the future to handle those issues.

@nofurtherinformation
nofurtherinformation merged commit 3ec4bfc into main Aug 21, 2025
2 checks passed
@nofurtherinformation
nofurtherinformation deleted the map-galleries branch August 21, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants