Skip to content

Commit 050566d

Browse files
committed
Merge branch 'develop' into main
2 parents ba28192 + 48aea8c commit 050566d

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

app/modules/hubfile/models.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,16 @@ def get_ide_url(self) -> str:
8686
return f"https://ide.flamapy.org/?import={self._public_raw_url()}"
8787

8888
def get_factlabel_url(self) -> str:
89-
"""Return the URL that opens this hubfile in FactLabel."""
90-
return f"https://fmfactlabel.github.io/app/?v=1.8.0&file={self._public_raw_url()}"
89+
"""Return the URL that opens this hubfile in FactLabel.
90+
91+
Note: we deliberately don't pass `?v=<version>`. FactLabel's JS
92+
compares the URL's `v` against its own version.json and redirects
93+
to /error_version.html (which is a 404 on GitHub Pages) when they
94+
don't match. Hardcoding `v=1.8.0` here broke as soon as FactLabel
95+
bumped to 1.8.1. Omitting the param skips the check entirely and
96+
lets FactLabel pick up whatever version it's currently serving.
97+
"""
98+
return f"https://fmfactlabel.github.io/app/?file={self._public_raw_url()}"
9199

92100
def to_dict(self):
93101
from flask import url_for

0 commit comments

Comments
 (0)