Skip to content

Added noindex meta tag to untranslated docs pages #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vidhiii1711 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added noindex meta tag to untranslated docs pages #2473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa1dfa6
Added noindex meta tag to untranslated docs pages
vidhiii1711 Jan 24, 2026
c40668e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 24, 2026
414bdd0
Fix noindex logic and add tests
vidhiii1711 Mar 17, 2026
d37d3f2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 17, 2026
a20126b
Fix tests using ReleaseMixin and correct language handling
vidhiii1711 Mar 19, 2026
49d38b2
Fix tests using reverse('home') for correct URL resolution
vidhiii1711 Mar 19, 2026
f769b9c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions accounts/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,3 +240,14 @@ def test_view_deletion_also_logs_out(self):
self.client.force_login(user)
self.client.post(reverse("delete_profile"))
self.assertEqual(self.client.cookies["sessionid"].value, "")


class NoIndexMetaTagTests(ReleaseMixin, TestCase):

def test_noindex_present_on_untranslated_page(self):
response = self.client.get(reverse("home"))
self.assertContains(response, "noindex")

def test_noindex_not_present_on_translated_page(self):
response = self.client.get(reverse("home", kwargs={"lang": "fr"}))
self.assertNotContains(response, "noindex")
Binary file added db.sqlite3
View file
Open in desktop
Binary file not shown.
7 changes: 6 additions & 1 deletion djangoproject/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@
<link rel="stylesheet" href="{% static "css/output.css" %}" >

<script src="{% static "js/mod/switch-dark-mode.js" %}"></script>
{% block head_extra %}{% endblock head_extra %}
{% block head_extra %}
{% if request.LANGUAGE_CODE != 'en' %}
<meta name="robots" content="noindex">
{% endif %}
{% endblock head_extra %}

</head>

<body id="{% block sectionid %}generic{% endblock %}" class="{% block body_class %}{% endblock %}">
Expand Down
Loading