-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
i18n: add missing header, menu, subfooter, footer and search strings … #2502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
14c80d3
f7ce753
0adfc3b
7a7b7ee
7a856b1
ce25dac
d2f2eb0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,68 +1,66 @@ | ||||||
| {% load i18n %} | ||||||
| {% load hosts %} | ||||||
|
|
||||||
| <footer> | ||||||
| <div class="subfooter"> | ||||||
| <div class="container"> | ||||||
| <h2 class="visuallyhidden">Django Links</h2> | ||||||
| <h2 class="visuallyhidden">{% trans "Django Links" %}</h2> | ||||||
| <div class="column-container"> | ||||||
| <div class="col-learn-more"> | ||||||
| <h3>Learn More</h3> | ||||||
| <h3>{% trans "Learn More" %}</h3> | ||||||
| <ul> | ||||||
| <li><a href="{% url 'overview' %}">About Django</a></li> | ||||||
| <li><a href="{% url 'overview' %}">{% trans "About Django" %}</a></li> | ||||||
| {% comment %}<li><a href="{% url 'case_study_index' %}">Case Studies</a></li>{% endcomment %} | ||||||
| <li><a href="{% url 'start' %}">Getting Started with Django</a></li> | ||||||
| <li><a href="{% url 'members:teams' %}">Team Organization</a></li> | ||||||
| <li><a href="{% url 'homepage' %}foundation/">Django Software Foundation</a></li> | ||||||
| <li><a href="{% url 'code_of_conduct' %}">Code of Conduct</a></li> | ||||||
| <li><a href="{% url 'diversity' %}">Diversity Statement</a></li> | ||||||
| <li><a href="{% url 'start' %}">{% trans "Getting Started with Django" %}</a></li> | ||||||
| <li><a href="{% url 'members:teams' %}">{% trans "Team Organization" %}</a></li> | ||||||
| <li><a href="{% url 'homepage' %}foundation/">{% trans "Django Software Foundation" %}</a></li> | ||||||
| <li><a href="{% url 'code_of_conduct' %}">{% trans "Code of Conduct" %}</a></li> | ||||||
| <li><a href="{% url 'diversity' %}">{% trans "Diversity Statement" %}</a></li> | ||||||
| </ul> | ||||||
| </div> | ||||||
|
|
||||||
| <div class="col-get-involved"> | ||||||
| <h3>Get Involved</h3> | ||||||
| <h3>{% trans "Get Involved" %}</h3> | ||||||
| <ul> | ||||||
| <li><a href="{% url 'community-index' %}">Join a Group</a></li> | ||||||
| <li><a href="{% url 'document-detail' lang='en' version='dev' url="internals/contributing" host 'docs' %}">Contribute | ||||||
| to Django</a></li> | ||||||
| <li><a href="{% url 'community-index' %}">{% trans "Join a Group" %}</a></li> | ||||||
| <li><a href="{% url 'document-detail' lang='en' version='dev' url="internals/contributing" host 'docs' %}">{% trans "Contribute to Django" %}</a></li> | ||||||
| <li><a | ||||||
| href="{% url 'document-detail' lang='en' version='dev' url="internals/contributing/bugs-and-features" host 'docs' %}">Submit | ||||||
| a Bug</a></li> | ||||||
| href="{% url 'document-detail' lang='en' version='dev' url="internals/contributing/bugs-and-features" host 'docs' %}">{% trans "Submit a Bug" %}</a></li> | ||||||
| <li><a | ||||||
| href="{% url 'document-detail' lang='en' version='dev' url="internals/security" host 'docs' %}#reporting-security-issues">Report | ||||||
| a Security Issue</a></li> | ||||||
| <li><a href="{% url 'members:individual-members' %}">Individual membership</a></li> | ||||||
| href="{% url 'document-detail' lang='en' version='dev' url="internals/security" host 'docs' %}#reporting-security-issues">{% trans "Report a Security Issue" %}</a></li> | ||||||
| <li><a href="{% url 'members:individual-members' %}">{% trans "Individual membership" %}</a></li> | ||||||
| </ul> | ||||||
| </div> | ||||||
|
|
||||||
| <div class="col-get-help"> | ||||||
| <h3>Get Help</h3> | ||||||
| <h3>{% trans "Get Help" %}</h3> | ||||||
| <ul> | ||||||
| <li><a href="{% url 'document-detail' lang='en' version='stable' url='faq' host 'docs' %}">Getting Help FAQ</a> | ||||||
| <li><a href="{% url 'document-detail' lang='en' version='stable' url='faq' host 'docs' %}">{% trans "Getting Help FAQ" %}</a> | ||||||
|
||||||
| <li><a href="{% url 'document-detail' lang='en' version='stable' url='faq' host 'docs' %}">{% trans "Getting Help FAQ" %}</a> | |
| <li><a href="{% url 'document-detail' lang='en' version='stable' url='faq' host 'docs' %}">{% trans "Getting Help & FAQ" %}</a> |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're at it:
| <li><a href="https://chat.djangoproject.com" target="_blank">{% trans "Django Discord" %}</a></li> | |
| <li><a href="https://chat.djangoproject.com" target="_blank">{% trans "Django's Discord Server" %}</a></li> |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off Topic: Do we still do X? Doesn't that inherently violate the CoC? 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off Topic: Do we still do X? Doesn't that inherently violate the CoC? 😏
Thanks for the note! I’m working on the other suggested changes. Regarding X, my understanding is that it refers to the current name for Twitter. I’ve kept the existing link as-is for now, but I’m happy to update or remove it if the maintainers prefer a different approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, this was a joke. Since X formerly Twitter, largely abandoned content moderation. Whereas this community stands much firmer on its values.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since those are brand names, I don't believe they need a translation.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| {% load i18n %} | ||
| <search class="search form-input" aria-labelledby="docs-search-label"> | ||
| <form action="{% url 'document-search' version=version lang=lang host 'docs' %}"> | ||
| <label id="docs-search-label" class="visuallyhidden" for="{{ form.q.id_for_label }}">{{ form.q.field.widget.attrs.placeholder }}</label> | ||
| <label id="docs-search-label" class="visuallyhidden" for="{{ form.q.id_for_label }}">{% trans "Search" %}</label> | ||
| {{ form.q }} | ||
| <input type="hidden" name="category" value="{{ active_category }}"> | ||
|
|
||
| <button type="submit"> | ||
| <i class="icon icon-search" aria-hidden="true"></i> | ||
| <span class="visuallyhidden">{% translate "Submit" %}</span> | ||
| <span class="visuallyhidden">{% trans "Submit" %}</span> | ||
| </button> | ||
| </form> | ||
| </search> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off topic: Lots of hardcoded URLs in here.