Replace collapsing list component with details#2528
Open
adamzap wants to merge 2 commits intodjango:mainfrom
Open
Replace collapsing list component with details#2528adamzap wants to merge 2 commits intodjango:mainfrom
details#2528adamzap wants to merge 2 commits intodjango:mainfrom
Conversation
The collapsing list component was not used much and required non-trivial JavaScript. This patch replaces all uses of it with the `details` and `summary` elements. It has also been removed from the style guide.
for more information, see https://pre-commit.ci
Contributor
|
I can take a look at implementing the styling to make it look closer to what we had before. I think I would still prefer to have the "expand all/collapse all" button progressively added through JS, so that if someone is not using JS, the individual expand/collapse still work, but if someone does use JS, they get that extra feature (yay progressive enhancement!). Thoughts @adamzap ? |
Member
Author
|
@SaptakS I'm good with that. Do you think we need the expand/collapse buttons on the blog sidebar though? Those seem a bit out of place to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collapsing list component was not used much and required non-trivial JavaScript. This patch replaces all uses of it with the
detailsandsummaryelements. It has also been removed from the style guide.Closes #2520
I think this is a good change, but this PR needs some design help:
Start page - Intro to Django
Before:
After:
Community - Django RSS Feeds
Before:
After:
News - Sidebar - Archives
Before:
After: