Fix dead FAQ link and broken anchors on the fundraising page#2628
Fix dead FAQ link and broken anchors on the fundraising page#2628ericholscher wants to merge 2 commits into
Conversation
The "Frequently Asked Questions" link pointed at the fundraising page itself (there is no donations FAQ page), so it just reloaded the page. The Benevity and "tax deductible" links pointed at #benevity-giving and #tax-deductible anchors that do not exist on the page. Remove the dead FAQ sentence and unwrap the two anchor links to plain text.
adamzap
left a comment
adamzap
left a comment
There was a problem hiding this comment.
👍 Looks great! I'd also like to hear from whoever owns the content of the page.
| <a href="{{ fundraising_url }}#benevity-giving">Benevity Workplace Giving | ||
| Program</a> - If your employer participates, you can make donations to the | ||
| DSF via payroll deduction. | ||
| Benevity Workplace Giving Program - If your employer participates, you can |
There was a problem hiding this comment.
I wonder if this should point to somewhere like here?
There's also a bad link in the footer. However, this may be out of scope.
There was a problem hiding this comment.
Perhaps. I was mostly trying to clean up obviously broken things. There's a bunch that could be improved, but didn't want to expand the scope so it would be easy to merge.
There was a problem hiding this comment.
Looking at the history, I'm pretty sure the intended target of this link is https://www.djangoproject.com/foundation/donate/#benevity-giving (in the flatpages, see #2654 (comment)). And that has useful additional info for anyone interested, so might be better than removing the link.
I don't think a link to Benevity's site would be helpful here: it's all targeted to employers who would engage Benevity to manage a charitable payroll deduction program. I couldn't find any useful info there for employees who want to contribute to a charitable organization through such a program.
Incidentally, the broken footer link was apparently meant to target this <li> (though maybe should be repointed directly to the foundation/donate content instead).
There was a problem hiding this comment.
Yea, I'm guessing the content was moved at some point, and the links weren't updated? I've updated the PR to point at the right pages -- thanks for the note!
| itself, you should donate today</strong> (may be <a href="{{ fundraising_url }}#tax-deductible">tax deductible</a>). | ||
| itself, you should donate today</strong> (may be tax deductible). |
There was a problem hiding this comment.
If possible, it would be good to link this to https://www.djangoproject.com/foundation/donate/#tax-deductible (which provides additional information), rather than removing the link altogether.
Per PR review: the intended targets are the anchors on the /foundation/donate/ flatpage, not removal.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2628 +/- ##
=======================================
Coverage ? 86.84%
=======================================
Files ? 188
Lines ? 6947
Branches ? 392
=======================================
Hits ? 6033
Misses ? 832
Partials ? 82 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 participants
The fundraising page has a "Frequently Asked Questions" link that points back to the page itself, plus two links to in-page anchors that don't exist.