[smtp-relay] Nobble log ingrestion to allow metrics startup - #148
Open
djjudas21 wants to merge 3 commits into
Open
[smtp-relay] Nobble log ingrestion to allow metrics startup#148djjudas21 wants to merge 3 commits into
djjudas21 wants to merge 3 commits into
Conversation
Owner
Author
|
@leleobhz what do you think about this PR? 🙂 |
Contributor
|
I think this is a good start, but some logic for log rotating postfix logs or test if FIFO files are compatible with both postfix and kumina collector may be a next step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
At the moment it is not possible for the metrics exporter to read
/var/log/maillogfrom the Postfix container without some additional engineering work on log rotation and possibly even shared volumes - discussion in #146 (comment)As a workaround, this PR causes the metrics exporter to open a fake Postfix logfile from
/dev/null, so it can start up without crashing. This means the metrics exporter will not have access to the Postfix event log (it still has access to the Postfix socket) so it will report a reduced set of metrics. At the moment I'm not sure what it will report.It should still be possible to measure the queue length and ensure the exporter is working properly, but it might fail to report the number of messages transmitted, etc.
Which issue this PR fixes
Checklist
[prometheus-couchdb-exporter])