Bump Topola: skip fanout/layer panics on dense boards - #2
Merged
Conversation
Pin third_party/topola to the fork commit that skips failed anteroute fanouts and cross-layer navmesh pairs instead of panicking, and drop the now-redundant contrib patch. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands the unfinished Topola dense-board robustness fix that was sitting dirty in
third_party/topola.djmango/topola@6723e31onfeature/cli-multilayer-remaining(also updates mikwielgus/topola#1): skip failed anteroute fanouts and returnNavmeshError::LayerMismatchinstead of panicking.contrib/topolapatch.Verification
bun run smoke:autoroute— OK (2 traces)bun run pcbkit:smoke— exit 0ci/artifacts/v3-for-route.dsn,--wall-timeout 60): Topola hitanteroute fanout failed … skipping pin, finished multilayer autorouting, wrote SES, exit 0 (previously this pathpanic!()'d)Test plan
bun run smoke:autoroutebun run pcbkit:smokeci/artifacts/v3-for-route.dsncompletes without panic and writes SES