Skip to content

Changed chromedriver string to dynamic from static - #3

Open
drpresq wants to merge 1 commit into
dkkocab:mainfrom
drpresq:feature_dynamic-chromedriver
Open

Changed chromedriver string to dynamic from static#3
drpresq wants to merge 1 commit into
dkkocab:mainfrom
drpresq:feature_dynamic-chromedriver

Conversation

@drpresq

@drpresq drpresq commented Nov 22, 2020

Copy link
Copy Markdown

Changed chromedriver string to dynamic from static
Various PEP 8 formatting adjustments

Various PEP 8 formatting adjustments

@dkkocab dkkocab left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works for linux correct?

@drpresq

drpresq commented Nov 23, 2020

Copy link
Copy Markdown
Author

It should work for both Linux and Windows. If the platform is Linux it runs find / -iname chromedriver 2>/dev/null. If the platform is not linux it assumes windows and runs dir C:\chromedriver.exe /b/s which returns the path to chromedriver.exe starting from the C drive.

dkkocab pushed a commit that referenced this pull request Jan 3, 2021
Merge Yitong's branch into Hong's
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants