Skip to content

Fix #22902 - Named arguments not cleared after re-ordering#22904

Merged
thewilsonator merged 1 commit intodlang:masterfrom
dkorpel:namedarg-clear
Apr 9, 2026
Merged

Fix #22902 - Named arguments not cleared after re-ordering#22904
thewilsonator merged 1 commit intodlang:masterfrom
dkorpel:namedarg-clear

Conversation

@dkorpel
Copy link
Copy Markdown
Contributor

@dkorpel dkorpel commented Apr 9, 2026

Closes #22902

Split off from #22903

exp.names = null; can't be done inside functionParameters because the current parameter lists takes an argumentList by value, copying the pointer instead of passing it by ref. I think functionParameters should just take the CallExp directly, but I rather do that in a follow up refactoring PR.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22904"

@thewilsonator thewilsonator merged commit cd441f7 into dlang:master Apr 9, 2026
39 of 42 checks passed
@dkorpel dkorpel deleted the namedarg-clear branch April 9, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Named arguments not cleared after re-ordering

3 participants