use ErrorStatment.get() instead of new ErrorStatement - #23466
Merged
Conversation
rainers
reviewed
Jul 27, 2026
rainers
left a comment
rainers
left a comment
Member
There was a problem hiding this comment.
The get-method is fine, but if you want to help reduce the diff for dmd as a library, you could pass the original statement to get so it can be saved for inspection later, see also #23467 (comment)
thewilsonator
force-pushed
the
error-statment
branch
2 times, most recently
from
July 28, 2026 23:51
8db7b5e to
2dd62b2
Compare
thewilsonator
force-pushed
the
error-statment
branch
from
July 28, 2026 23:57
2dd62b2 to
a1c750b
Compare
rainers
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.