Skip to content

Doc / workflow changes to trigger PR workflow#70

Merged
dlarrick merged 5 commits into
masterfrom
dcl_workflow
May 25, 2026
Merged

Doc / workflow changes to trigger PR workflow#70
dlarrick merged 5 commits into
masterfrom
dcl_workflow

Conversation

@dlarrick

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository documentation and GitHub Actions to better support development workflows, including running pre-commit and tests on pull requests.

Changes:

  • Add a “Development” section to the README with contributor/pre-commit guidance.
  • Update pre-commit hook revisions.
  • Rework the pull-request CI workflow to run pre-commit and adjust the test matrix / action versions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
README.md Adds contributor/development guidance, including pre-commit usage and PR behavior.
.pre-commit-config.yaml Updates the pinned version of pre-commit-hooks.
.github/workflows/pull-request-check.yml Renames/retools the PR workflow and adds a pre-commit run step.
Comments suppressed due to low confidence (3)

.github/workflows/pull-request-check.yml:17

  • The steps list is mis-indented: - uses: ... is aligned with steps: instead of being nested under it. This makes the workflow YAML invalid and the job won’t run. Indent the step entries under steps: (e.g., steps: followed by - ...).
    .github/workflows/pull-request-check.yml:6
  • This workflow is configured to run only for PRs targeting master, but the repository context/diff indicates the default branch is main (the previous config targeted main). As written, the workflow won’t trigger for PRs into main. Update the target branch (or remove the branch filter if you want it for all PRs).

This issue also appears in the following locations of the same file:

  • line 14
  • line 30
    .github/workflows/pull-request-check.yml:34
  • pre-commit run --from-ref origin/master --to-ref HEAD hard-codes the base branch name. This will fail when the PR base branch isn’t master (e.g., main) and is also brittle for repos that rename default branches. Use the PR’s actual base ref/SHA (e.g., ${{ github.base_ref }} / ${{ github.event.pull_request.base.sha }}) instead of a fixed origin/master.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dlarrick dlarrick merged commit df43a65 into master May 25, 2026
6 checks passed
@dlarrick dlarrick deleted the dcl_workflow branch May 25, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants