feat(smaf): SMAF loop & MIDI pitch bend/SysEx - #1241
Merged
Conversation
… support Wire the repeat parameter from WIPI C (MC_mdaPlay) and Java (org.kwis.msp.media.Player.play) down to the backend audio system. SmafPlaye play now loops when repeat is true, stopping only when the stop flag is set. Also extend AudioSink with midi_pitch_bend and midi_sysex methods to match the upstream smaf_player SmafEvent variants, and add regression tests for one-shot and looped playback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About: dlunch/smaf#66
Wire the repeat parameter from WIPI C (MC_mdaPlay) and Java (org.kwis.msp.media.Player.play) down to the backend audio system.
SmafPlaye play now loops when repeat is true, stopping only when the stop flag is set.
Also extend AudioSink with midi_pitch_bend and midi_sysex methods to match the upstream smaf_player SmafEvent variants, and add regression tests for one-shot and looped playback.
2026.06.24 Update SMAF:
Cargo.lock4c4ca836Test Video:
bandicam.2026-06-23.12-19-01-757.mp4