Monitoring op scripts#1049
Conversation
ericvaandering
left a comment
There was a problem hiding this comment.
I don't have any comments on specific scripts, but on overall structure and some python stuff (which applies to multiple files, not just where it is noted)
There was a problem hiding this comment.
See comment below.
There was a problem hiding this comment.
What's in here. I want to make sure these binary files don't contain secrets of some sort.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
These files (cmsmonitoring.zip and stomp.zip) contain helper scripts to submit the spark jobs. I tried to replace them with the zip files provisioned by the base image [1], but unfortunately this made the jobs fail. I assume these files were added in order to patch these failures so they remain necessary.
There was a problem hiding this comment.
I think it makes sense to name this file something more specific that services. Should another group of pods need services, I'd like not to just keep expanding this.
Also is a service really needed for all these? They all have to be contacted by processes inside the cluster?
There was a problem hiding this comment.
Renamed to dmtops-cj-spark-services.yaml.
Yes, these services are necessary since the cronjobs submit Spark jobs to an external cluster, and the ports are needed for the jobs to communicate back. A separate service/port is used for each one of the cronjobs in order to prevent clashes between the jobs.
Migration monitoring cronjobs deployment (Fixes #904)
This PR addresses the implementation discussed in #904 by adding the monitoring cronjobs that are currently executed manually on the integration environment.
What changed
Monitoring scripts
Added the
docker/monitoringdirectory, containing the source code for the monitoring cronjobs. The directory is an exact copy of the relevant scripts from the existing monitoring repository ([3], [4], [5]).The following cronjobs are included:
Helm chart
Updated the
helm/rucio-cron-jobschart to deploy the new monitoring jobs, including:The chart version has been bumped to 4.1.0.
This work continues the deployment effort started in #910.
CI/CD
Added a GitHub Actions workflow to automatically build and publish the cmsrucio/dmops-spark-crons image.
The workflow is triggered by releases whose tag starts with:
monitoring-References
[1] CMSTRANSF-1366
[2] CMSTRANSF-1264
[3] https://gitlab.cern.ch/cmsdmops/cmsdmops/-/merge_requests/28/diffs
[4] https://gitlab.cern.ch/cmsdmops/cmsdmops/-/merge_requests/25/diffs
[5] https://gitlab.cern.ch/cmsdmops/cmsdmops/-/tree/master/monitoring/kubernetes?ref_type=heads