Skip to content

Add error handling for job submission and micro-architecture fetching #12420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hassan11196 wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

Add error handling for job submission and micro-architecture fetching #12420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/python/WMCore/BossAir/Plugins/SimpleCondorPlugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,14 @@ def submit(self, jobs, info=None):

# Submit the jobs
for jobsReady in grouper(jobs, self.jobsPerSubmit):

(sub, jobParams) = self.createSubmitRequest(jobsReady)

try:
(sub, jobParams) = self.createSubmitRequest(jobsReady)
except Exception as ex:
logging.error("Failed to create submit request for %d jobs", len(jobsReady))
logging.exception(str(ex))
logging.error("Moving on the the next batch of jobs and/or cycle....")
return successfulJobs, failedJobs
Copy link
Copy Markdown
Contributor

@amaltaro amaltaro Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that these 2 variables can potentially be empty (or not tracking jobs yet to be submitted), I think this will cause issues upstream.
The best would be to iterate over all those (remaining) jobs and add them to the failedJobs variable, before returning it - similar to what is done in the exception block below.


logging.debug("Start: Submitting %d jobs using Condor Python Submit", len(jobParams))
try:
Expand Down