Bypass NoPendingSlot limit for Merge job type to prevent blocking by …#12490
Open
hassan11196 wants to merge 1 commit intomasterfrom
Open
Bypass NoPendingSlot limit for Merge job type to prevent blocking by …#12490hassan11196 wants to merge 1 commit intomasterfrom
hassan11196 wants to merge 1 commit intomasterfrom
Conversation
…pending slot limits
Member
Author
|
test this please |
1 similar comment
Member
Author
|
test this please |
|
Jenkins results:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bypasses the pendingslot limit for jobs at a given site.
Fixes #12361
Status
In development
Description
This PR is a test change to bypass the NoPendingSlots limit in JobSubmitter.
For Example, The following site has reached its threshold of max Pending slots and cannot submit anymore jobs.
and the JobSubmitter has alot of merge jobs pending which cannot be submitted, despite the fact that the Merge pending job limit is not reached, in this case 0 Merge jobs are pending or running.
This PR is to bypass the NoPendingSlot limit but keep the NoTaskPendingSlot limit so that the Merge jobs are not held in the agents due to Production jobs pending.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
#12415
External dependencies / deployment changes
No
Previous PR
#12471