Remove deprecated EmailForward from and to fields#329
Merged
Conversation
The `from` and `to` fields in the EmailForward schema were deprecated on 2021-01-25 in favor of `alias_email` and `destination_email`. The server stopped emitting them on 2026-02-24 and stopped accepting them as input on 2026-03-03. Remove them from the `EmailForward` defstruct. This is a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the deprecated
fromandtofields from theEmailForwarddefstruct. These fields were renamed toalias_emailanddestination_emailon 2021-01-25. The server stopped emitting them on 2026-02-24 and stopped accepting them as input on 2026-03-03.This is a breaking change.
Tracking PR: dnsimple/dnsimple-developer#988
Test plan
mix testpasses