Add support for domain research endpoint#450
Merged
Merged
Conversation
Contributor
Author
|
I'll wait for a ✅ before moving into new clients. As I want us to agree first on nomenclature, and naming convention of objects / classes, etc. |
jacegu
approved these changes
Feb 16, 2026
Comment on lines
+1
to
+16
| HTTP/1.1 200 OK | ||
| server: nginx | ||
| date: Fri, 13 Feb 2026 16:04:05 GMT | ||
| content-type: application/json; charset=utf-8 | ||
| connection: keep-alive | ||
| status: 200 OK | ||
| x-ratelimit-limit: 4000 | ||
| x-ratelimit-remaining: 3999 | ||
| x-ratelimit-reset: 1456506245 | ||
| etag: W/"f3cf8499e935e48401aae26842f712c4" | ||
| cache-control: max-age=0, private, must-revalidate | ||
| x-request-id: e3c6fac1-a36d-42c3-8a04-d68f127add18 | ||
| x-runtime: 0.605907 | ||
| strict-transport-security: max-age=31536000 | ||
|
|
||
| {"data":{"request_id":"f453dabc-a27e-4bf1-a93e-f263577ffaae","domain":"example.com","availability":"unavailable","errors":[]}} |
Contributor
There was a problem hiding this comment.
We should add this to the developer repo
Contributor
There was a problem hiding this comment.
| # @return [String] The domain name that was researched. | ||
| attr_accessor :domain | ||
|
|
||
| # @return [String] The availability status. Possible values: available, unavailable, unknown |
Contributor
There was a problem hiding this comment.
I would reference the API docs here, rather than listing the values, just thinking about making these docs less prone to obsolescence / incompleteness.
jacegu
reviewed
Feb 17, 2026
| response = client.get(endpoint, options) | ||
|
|
||
| Dnsimple::Response.new(response, Struct::DomainResearch.new(response["data"])) | ||
| end |
Contributor
There was a problem hiding this comment.
Looking closer at this, the only thing I am wondering is whether to add a new domains_research.rb file specific to this endpoint.
Contributor
|
@juankuquintana please, note #451. We need to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Belongs to https://github.com/dnsimple/dnsimple-business/issues/2442
Fixes https://github.com/dnsimple/dnsimple-app/issues/33829
Add support for domain research endpoint
🔍 QA
📋 Deployment Pre/Post tasks