103 doe documentation - #104
Merged
Merged
Conversation
Closed
am-kaiser
requested changes
Aug 8, 2025
am-kaiser
left a comment
am-kaiser
left a comment
Collaborator
There was a problem hiding this comment.
Really great work! Don't be discouraged by the number of comments. Most of them are just about spelling.
am-kaiser
reviewed
Aug 28, 2025
am-kaiser
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103
Added a more detailed DOE documentation page, I have tried to make it easy to understand for new users but I am very open to feedback. Also I have tried to only go into the most important parameters for the DoE specifically and not the QoI estimator, sampler and so on that also affect the DoE.
Additionally I have not added anything almost on optimization of the acqf function as I have not been able to look into it.