Added extra plotting of extreme response locations and example convergence to basic example - #79
Merged
Merged
Conversation
swinter1
reviewed
Jun 27, 2025
swinter1
left a comment
swinter1
left a comment
Collaborator
There was a problem hiding this comment.
Some parts of the code I am still reviewing (comments explain which parts) - but thought I would share the comments so far so we can divide and conquer.
swinter1
reviewed
Jun 30, 2025
…t files that should not have been included
swinter1
reviewed
Jun 30, 2025
…le_plots basic_example: plotting extreme response x locations and reponse surface
henrikstoklandberg
requested review from
am-kaiser and
swinter1
and removed request for
swinter1
July 1, 2025 05:32
…o match what was decided on for the new basic example
swinter1
approved these changes
Jul 4, 2025
swinter1
left a comment
swinter1
left a comment
Collaborator
There was a problem hiding this comment.
Pending the updated to stopping criteria i am happy for this to be merged
swinter1
reviewed
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have now added the pots I found most useful into the basic example at the points in the example I found it natural to add these, however I am open for suggestions to do it differently. Some questions I would appreciate the reviewer to consider would be: