Feature/64 importance sampling MarginalCDF test - #91
Merged
Conversation
am-kaiser
changed the title
am-kaiser
marked this pull request as ready for review
July 14, 2025 07:48
Collaborator
Author
|
I'd be especially interested in getting you impression if the comments are descriptive enough or if anything is unclear and can be better explained. I have decided to keep the integration test (if you can call it that) even though it does not really add much but I feel like it is still nice to have a minimal test just to check if the function runs. |
swinter1
requested changes
Jul 17, 2025
swinter1
left a comment
swinter1
left a comment
Collaborator
There was a problem hiding this comment.
Don't be put off by the number of comments, they are mainly cosmetic stuff - you've made a good start here, nice work.
swinter1
reviewed
Jul 17, 2025
swinter1
reviewed
Aug 6, 2025
swinter1
reviewed
Aug 12, 2025
swinter1
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Business need
Importance sampling is already used in the code for MarginalCDF which is in src but there are no tests to ensure that importance sampling works as desired.
Main issue:
Closes #64
Sub issues:
Notes
There will be a separate PR which tests the actual creation of the importance sampling (i.e. a test for the file importance_sampling.py which is currently part of the wave use case).