Skip to content

Moved from yarn to pnpm#467

Open
9larsons wants to merge 1 commit intodocker-library:masterfrom
9larsons:support-pnpm
Open

Moved from yarn to pnpm#467
9larsons wants to merge 1 commit intodocker-library:masterfrom
9larsons:support-pnpm

Conversation

@9larsons
Copy link
Copy Markdown

ref TryGhost/Ghost@f186b6a

Ghost moved over after 6.28 was cut from yarn to pnpm for the package manager. As yarn.lock no longer exists, we need to update the Docker image to point ot the pnpm-lock file and run corepack enable.

ref TryGhost/Ghost@f186b6a

Ghost moved over **after 6.28 was cut** from yarn to pnpm for the package manager. As `yarn.lock` no longer exists, we need to update the Docker image to point ot the `pnpm-lock` file and run `corepack enable`.
Comment on lines +65 to 70
RUN corepack enable

ENV GHOST_CLI_VERSION {{ .cli.version }}
RUN set -eux; \
npm install -g "ghost-cli@$GHOST_CLI_VERSION"; \
npm cache clean --force
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the docker folks can weigh in on this.

might make sense to move the corepack enable step into the same RUN command as the one installing the cli to avoid creating an extra layer

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I'm also a little concerned to see corepack enable here given that corepack is officially deprecated/removed in Node.js 25+ 😅 any thoughts/plans for what do about that?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 .....didn't know that, will look into the alternative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants