buildx(build): stabilize pull request git contexts#1067
Open
crazy-max wants to merge 1 commit intodocker:mainfrom
Open
buildx(build): stabilize pull request git contexts#1067crazy-max wants to merge 1 commit intodocker:mainfrom
crazy-max wants to merge 1 commit intodocker:mainfrom
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to: https://github.com/moby/buildkit/actions/runs/24232318835/job/70813734074#step:7:229
The
gitContextlogic now rewrites implicit PR merge refs togithub.context.shaand implicit PR head refs togithub.context.payload.pull_request.head.shabefore building either fragment or query URLs.BuildKit resolves remote PR refs at build time, so mutable PR refs can drift and no longer match the event commit.
actions/checkoutavoids that by fetching exact commits into local PR refs, and this change applies the same idea to remote git contexts so the build targets the event commit instead of whatever the PR ref happens to point to later.