handle no default attestations env var#1343
Merged
crazy-max merged 2 commits intodocker:masterfrom Apr 23, 2025
Merged
Conversation
93d7ffa to
515158f
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
515158f to
1c198f4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tonistiigi
reviewed
Apr 23, 2025
Member
tonistiigi
left a comment
There was a problem hiding this comment.
Is the issue that env is not propagated to buildx or does this need custom handling? If former then maybe a better fix would be to just make sure all BUILDX_* env are forwarded.
Member
Author
Yes it needs custom handling because the action is setting the provenance based on github events: build-push-action/src/context.ts Lines 248 to 260 in c566248 |
tonistiigi
approved these changes
Apr 23, 2025
rapids-bot bot
pushed a commit
to rapidsai/docker
that referenced
this pull request
Dec 2, 2025
Closes #820 *(description copied from #820 (comment) `build-*-manifest` CI jobs are failing like this: ```text docker.io/rapidsai/staging:docker-cuvs-bench-820-26.02a-cuda13-py3.10-amd64 is a manifest list Error: Process completed with exit code 1. ``` ([build link](https://github.com/rapidsai/docker/actions/runs/19864919436/job/56926457521?pr=820#step:4:23)) Looks like in newer versions of `docker`, builds create manifest lists by default instead of single image builds: * NVIDIA/gpu-operator#1940 * NVIDIA/k8s-driver-manager#132 * docker/build-push-action#1339 (comment) This opts out of that using the configuration option added in docker/build-push-action#1343 It also updates all `pre-commit` hooks, to avoid needing another CI run for #820 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1339
We should not set provenance attestation if
BUILDX_NO_DEFAULT_ATTESTATIONSenv var is set.