feat(version-tests): Add comprehensive API coverage to TagsTester#443
feat(version-tests): Add comprehensive API coverage to TagsTester#443Liljis wants to merge 1 commit intodocling-project:mainfrom
Conversation
edeandrea
left a comment
There was a problem hiding this comment.
Thanks @Liljis for this! See comments in-line.
The comments about "spelling out" the full class name apply in other places I saw. We can just import the classes.
Also, do you consider this PR complete? I was hoping to get some tests of more than just the convertSource operation too. Some of the async operations, chunking, etc.
Its fine either way. We can certainly "baby step" adding more tests, but I'm not going to consider #134 as "complete" until more tests of the other operations are added as well.
FWIW there are other unit tests in https://github.com/docling-project/docling-java/blob/main/docling-serve/docling-serve-client/src/test/java/ai/docling/serve/client/AbstractDoclingServeClientTests.java that can be "borrowed" and re-implemented here.
|
|
||
| assertThat(response.getResponseType()) | ||
| .as("Response type should be IN_BODY") | ||
| .isEqualTo(ai.docling.serve.api.convert.response.ResponseType.IN_BODY); |
There was a problem hiding this comment.
We shouldn't need to "spell out" the entire import ai.docling.serve.api.convert.response.ResponseType? Just
.isEqualTo(ResponseType.IN_BODY);
| .doOcr(true) | ||
| .includeImages(true) | ||
| .tableMode(ai.docling.serve.api.convert.request.options.TableFormerMode.FAST) | ||
| .documentTimeout(Duration.ofMinutes(1)) |
There was a problem hiding this comment.
We shouldn't need to "spell out" the entire import ai.docling.serve.api.convert.request.options.TableFormerMode? Just
.tableMode(TableFormerMode.FAST)
eab892a to
d2596ce
Compare
|
Also, before I can merge this, can you please ensure both the DCO check and the semantic PR check passes? You may need to ammend your commit and do a signoff. |
:java_duke: JaCoCo coverage report
|
|
||||||||||||||
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
Description
Expanded the version compatibility tests in
TagsTester.javato include comprehensive API coverage beyond just the convert source endpoint, as requested in #134.Changes Made
Added 5 new test methods to
doConversion()inTagsTester.java:testConvertWithMultipleFormats - Tests conversion with MARKDOWN, JSON, and TEXT output formats ( already existed, done only refactoring)
testConvertWithJsonFormat - Validates JSON output and DoclingDocument deserialization
/v1/clear/convertersendpoint/v1/clear/resultsendpointMotivation
The previous implementation only tested the basic convert source API. This enhancement provides:
Test Results
results.md