fix: expose do_reading_order and force_backend_text pipeline options#117
Open
Frank-Schruefer wants to merge 1 commit intodocling-project:mainfrom
Open
Conversation
PdfPipelineOptions already supports do_reading_order and force_backend_text, but ConvertDocumentsOptions had no corresponding fields and manager.py did not pass them through to the pipeline. Add the missing fields and wire them up so callers can control reading-order prediction and native text extraction via the API. Signed-off-by: Frank Schruefer <frank.schruefer@t-online.de> Signed-off-by: stone <frank.schruefer@t-online.de>
Contributor
|
✅ DCO Check Passed Thanks @Frank-Schruefer, all your commits are properly signed off. 🎉 |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PdfPipelineOptionsalready supportsdo_reading_orderandforce_backend_text, but these options were not reachable via the API:ConvertDocumentsOptionshad no corresponding fieldsmanager.pydid not pass them through toPdfPipelineOptionsFix
do_reading_orderfield toConvertDocumentsOptions(defaulttrue)force_backend_textfield toConvertDocumentsOptions(defaultfalse)manager.pyWhy it matters
do_reading_order=falseis useful for PDFs where the reading-order predictor produces incorrect results (e.g. scanned PDFs with a native text layer and many small orphan clusters).force_backend_textis useful for PDFs with reliable programmatic text layers where layout-model text detection is unnecessary.