Add support for blameable on remove#2929
Add support for blameable on remove#2929oojacoboo wants to merge 16 commits intodoctrine-extensions:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
==========================================
+ Coverage 78.75% 78.80% +0.04%
==========================================
Files 169 169
Lines 8695 8715 +20
==========================================
+ Hits 6848 6868 +20
Misses 1847 1847 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Couple things here:
|
You are removing |
|
@phansys I've resolved the PHPStan issues. I'm a bit confused with what's going on with PHPStan on this lib, though. There is a Also, IMO, it'd be a good idea to drop support for some of these unsupported versions of PHP. It's holding back the lib and making updates and codestyle much more difficult. Please let me know if anything else is needed here - should be ready. |
|
@phansys I've merged in the latest changes. There weren't any conflicts though, so it wasn't actually necessary. But that's been done. I'm unsure about this failing test though. That seems to be preexisting, unless I'm misunderstanding something. |
This PR adds support for blameable on
remove/deletion of an entity. This can be very useful, when used in conjunction with soft-delete. It obviously is useless without soft-delete.Docs have been updated a tests added.