Skip to content

[#2006] Allow integer type for blamable fields#2949

Open
sgehrig wants to merge 4 commits intodoctrine-extensions:mainfrom
sgehrig:bug/#2006-blamable-integer
Open

[#2006] Allow integer type for blamable fields#2949
sgehrig wants to merge 4 commits intodoctrine-extensions:mainfrom
sgehrig:bug/#2006-blamable-integer

Conversation

@sgehrig
Copy link
Copy Markdown

@sgehrig sgehrig commented May 15, 2025

As discussed in #2006 it is currently not possible to have blamable fields backed by integer columns. This PR (re-) adds the integer type to the list of valid field types.

Comment thread tests/Gedmo/Blameable/BlameableIntegerTest.php Outdated
Comment thread tests/Gedmo/Blameable/BlameableIntegerTest.php Outdated
@VincentLanglet
Copy link
Copy Markdown
Contributor

Should type like bigint, smallint be added too ?

@sgehrig
Copy link
Copy Markdown
Author

sgehrig commented Sep 25, 2025

@phansys I added the changelog entry.

@sgehrig
Copy link
Copy Markdown
Author

sgehrig commented Sep 25, 2025

@phansys @VincentLanglet
I can add bigint and smallint as well if needed. I just added integer because that's what I needed and what was discussed in #2006. Adding the other two should not be any problem at all.

@sgehrig
Copy link
Copy Markdown
Author

sgehrig commented Jan 12, 2026

Is there any chance to have this merged?

sgehrig and others added 4 commits March 10, 2026 15:14
doctrine uses `integer` if the column is of type `int`

Signed-off-by: Stefan Gehrig <stefan.gehrig.hn@googlemail.com>
Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
Co-authored-by: Javier Spagnoletti <phansys@gmail.com>
Signed-off-by: Stefan Gehrig <stefan.gehrig.hn@googlemail.com>
@sgehrig sgehrig force-pushed the bug/#2006-blamable-integer branch from d970a0d to 0501425 Compare March 10, 2026 14:15
@sgehrig
Copy link
Copy Markdown
Author

sgehrig commented Mar 10, 2026

Branch has been rebased.
Is there any chance to have this one merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants