Fix Loggable template bounds for Symfony TypeInfo compatibility#3046
Open
Prometee wants to merge 1 commit intodoctrine-extensions:mainfrom
Open
Fix Loggable template bounds for Symfony TypeInfo compatibility#3046Prometee wants to merge 1 commit intodoctrine-extensions:mainfrom
Prometee wants to merge 1 commit intodoctrine-extensions:mainfrom
Conversation
Contributor
|
I dare suggest this should go the other way around and just be an object. None of the extensions require entities to implement the marker interfaces (of which this Loggable interface is one), so the generic type only supporting the marker interface would create other static analysis issues if you aren't implementing them. (Long term since they offer no value to this library, maybe they should just be deprecated and let applications have their own marker interfaces if they so choose?) |
Prometee
force-pushed
the
fix/loggable-template-type-info-3044
branch
from
8ae7d5c to
9824f91
Compare
mbabker
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3044.
What
This PR updates 3 Loggable PHPDoc template bounds that currently combine
Loggableandobjectin the same bound:src/Loggable/LoggableListener.phpsrc/Loggable/Entity/MappedSuperclass/AbstractLogEntry.phpsrc/Loggable/LogEntryInterface.phpThe bound is simplified to
object.Why
Recent versions of
symfony/type-infoparse@phpstan-template/@psalm-templateannotations and reject bounds combiningobjectwith a specific class/interface.This causes the incompatibility reported in #3044.
Scope / BC