[Tree] Fix recover() not forwarding treeRootNode to verify(), causing unscoped forest verification#3048
Open
ashrafthamir wants to merge 1 commit intodoctrine-extensions:mainfrom
Conversation
…ed forest verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
recover()accepts atreeRootNodeoption to scope recovery to a single tree, but the internalverify()call does not forward it. This causesverify()to check the entire forest instead of only the target tree.If any other tree in the forest has errors, the early-exit optimisation is bypassed and the target tree is unnecessarily recovered. At scale (many roots, large trees), the unscoped
verify()iterates every lft/rgt index across all trees, producing a query per index and leading to timeouts.Solution
Forward treeRootNode to verify(), which already supports it.