fix(web_crawler): remove redundant extract_max_priority_page call in crawl loop - #1373
Open
aoright wants to merge 1 commit into
Open
Conversation
…crawl loop Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
solutions/system_design/web_crawler/web_crawler_snippets.py, theCrawler.crawlmethod calledself.data_store.extract_max_priority_page()at the end of thewhile Trueloop, which was immediately overwritten by the call at the top of the next iteration. This caused every alternate highest priority page to be popped from the queue and discarded without being crawled.README.md.