Conversation
|
🚀 Surge Preview has been successfully deployed! Preview URL: https://doocs-md-preview-pr-1443.surge.sh Built with commit 49a5efb |
There was a problem hiding this comment.
Pull request overview
Upgrades key dependencies used across the monorepo (CodeMirror view + Marked) and updates the pnpm patching setup accordingly, affecting both the web app and the core markdown renderer packages.
Changes:
- Bump
@codemirror/viewfrom6.40.0→6.41.0and update the correspondingpatchedDependenciesentry + patch file. - Bump
markedfrom^17.0.6→^18.0.0across packages that depend on it. - Remove
compilerOptions.baseUrlfromapps/webandpackages/coretsconfigs.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates @codemirror/view override and points patchedDependencies to the new patch/version. |
| pnpm-lock.yaml | Regenerates lockfile to reflect @codemirror/view@6.41.0 (patched) and marked@18.0.0. |
| patches/@codemirror__view@6.41.0.patch | Patch for @codemirror/view@6.41.0 (d.ts export + keybinding behavior tweak). |
| packages/shared/package.json | Upgrades marked dependency range to ^18.0.0. |
| packages/core/tsconfig.json | Removes baseUrl while keeping paths mapping. |
| packages/core/package.json | Upgrades marked dependency range to ^18.0.0. |
| package.json | Pins root @codemirror/view to 6.41.0. |
| apps/web/tsconfig.app.json | Removes baseUrl while keeping paths mapping. |
| apps/web/package.json | Upgrades marked dependency range to ^18.0.0. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/core/tsconfig.json:7
compilerOptions.pathsrequirescompilerOptions.baseUrl(either in this file or inherited). SincebaseUrlwas removed and the base tsconfig doesn’t define it, TypeScript will error and the@/*alias won’t work. Re-add"baseUrl": "."here (or move it into the shared base config and ensure this config inherits it).
"extends": "@md/config/tsconfig.base.json",
"compilerOptions": {
"paths": {
"@/*": ["./src/*"]
}
},
| @@ -1,7 +1,6 @@ | |||
| { | |||
| "extends": "@md/config/tsconfig.base.json", | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
compilerOptions.paths requires compilerOptions.baseUrl (either in this file or inherited). Since baseUrl was removed and the base tsconfig doesn’t define it, TypeScript will error and the @/* alias won’t work. Re-add "baseUrl": "." here (or move it into the shared base config and ensure this config inherits it).
| "compilerOptions": { | |
| "compilerOptions": { | |
| "baseUrl": ".", |
|
🚀 Cloudflare Workers Preview has been successfully deployed! Preview URL: https://md-pr-1443.doocs.workers.dev Built with commit 49a5efb |
|
🗑️ Cloudflare Workers preview deployment has been cleaned up. |
No description provided.