Conversation
|
🚀 Cloudflare Workers Preview has been successfully deployed! Preview URL: https://md-pr-1445.doocs.workers.dev Built with commit 40ec43e |
|
🚀 Surge Preview has been successfully deployed! Preview URL: https://doocs-md-preview-pr-1445.surge.sh Built with commit 40ec43e |
There was a problem hiding this comment.
Pull request overview
Upgrades the juice dependency used by the Vue web app (for HTML/CSS inlining) to v11.1.1 and adds a pnpm patch to avoid a runtime failure when parsing inline style="" attributes.
Changes:
- Bump
juicefrom 11.0.3 to 11.1.1 inapps/web. - Move
juicefrom a workspace override to a pnpmpatchedDependenciesentry and add a patch forlib/inline.js. - Update
pnpm-lock.yamlto reflect the newjuiceversion, patch hash, and transitive dependency updates.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Removes juice override and adds juice@11.1.1 to patchedDependencies. |
| pnpm-lock.yaml | Updates lock entries for juice@11.1.1 (patched) and related transitive dependency graph changes. |
| patches/juice@11.1.1.patch | Adds a guard around utils.parseCSS(cssText) result access to prevent crashes on empty parses. |
| apps/web/package.json | Updates the juice dependency version specifier to ^11.1.1. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| yauzl: ^3.2.1 | ||
|
|
||
| patchedDependencies: | ||
| '@codemirror/view@6.41.0': patches/@codemirror__view@6.41.0.patch | ||
| juice@11.1.1: patches/juice@11.1.1.patch |
There was a problem hiding this comment.
patchedDependencies entries apply to a specific version (juice@11.1.1), but juice is no longer pinned via overrides (and apps/web now uses a caret range). This can cause the patch to stop applying if juice resolves to a newer 11.x in a future lockfile refresh. Consider pinning juice to 11.1.1 via overrides (similar to the existing @codemirror/view pattern) or keeping the dependency specifier exact so the patch is always used.
| "html-to-image": "^1.11.13", | ||
| "jszip": "^3.10.1", | ||
| "juice": "11.0.3", | ||
| "juice": "^11.1.1", |
There was a problem hiding this comment.
The dependency is now declared as "juice": "^11.1.1", but the repo applies a pnpm patch specifically for juice@11.1.1. Using a caret range makes it easy to accidentally upgrade to a newer 11.x where the patch won’t apply, potentially reintroducing the original issue. Consider pinning this to 11.1.1 (or add a workspace overrides pin) while a version-specific patch is required.
| "juice": "^11.1.1", | |
| "juice": "11.1.1", |
| '@typescript-eslint/project-service@8.56.1(typescript@5.9.3)': | ||
| dependencies: | ||
| '@typescript-eslint/tsconfig-utils': 8.56.1(typescript@5.9.3) | ||
| '@typescript-eslint/types': 8.56.1 | ||
| '@typescript-eslint/tsconfig-utils': 8.58.0(typescript@5.9.3) | ||
| '@typescript-eslint/types': 8.58.0 | ||
| debug: 4.4.3(supports-color@5.5.0) |
There was a problem hiding this comment.
This lockfile update includes changes unrelated to the stated "upgrade juice" scope (e.g., @typescript-eslint/tsconfig-utils / @typescript-eslint/types bump to 8.58.0 in this snapshot). If this wasn’t intentional, consider regenerating the lockfile in a way that only updates juice to keep the PR focused and reduce risk of unrelated toolchain changes.
|
🗑️ Cloudflare Workers preview deployment has been cleaned up. |
No description provided.