fix: Use parent URL for hidden configurable children#475
Merged
Conversation
davidmolinacano
requested changes
May 11, 2026
Contributor
There was a problem hiding this comment.
Bump this again, because I bumped it recently to 1.7.1 too
Suggested change
| <module name="Doofinder_Feed" setup_version="1.7.2"> |
Contributor
There was a problem hiding this comment.
Suggested change
| "version": "1.7.2", |
Contributor
There was a problem hiding this comment.
Suggested change
| "version": "1.7.2", |
sofia-doofinder
approved these changes
May 11, 2026
davidmolinacano
approved these changes
May 11, 2026
davidmolinacano
left a comment
davidmolinacano
left a comment
Contributor
There was a problem hiding this comment.
To avoid blocking you I leave it as approved, but don't forget to bump the version 😄
ogomezba
force-pushed
the
ogomezba/fix-hidden-configurable-child-url
branch
from
78a960e to
9bbd281
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/doofinder/support/issues/4983.
Parece que, para este cliente, el producto no tiene tipo Simple, sino Downloadable. El caso es que no veo tampoco un motivo claro para exigir que el producto tenga que ser simple. Si el producto tiene padres y no es visible por sí mismo, parece tener sentido añadir como enlace el del padre en cualquier caso.