Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/four-cameras-enter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@graphql-codegen/typescript-operations': patch
---

Fix Array used instead of ReadonlyArray while immutableTypes config is true
3 changes: 2 additions & 1 deletion packages/plugins/typescript/operations/src/visitor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@ export class TypeScriptDocumentsVisitor extends BaseDocumentsVisitor<
}

if (typeNode.type === 'ListType') {
typePart = `Array<${typePart}>`;
const listModifier = this.config.immutableTypes ? 'ReadonlyArray' : 'Array';
typePart = `${listModifier}<${typePart}>`;
if (!typeNode.isNonNullable) {
typePart = printTypeScriptMaybeType({
type: typePart,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,10 @@ describe('TypeScript Operations Plugin - Input', () => {
readonly to?: Date | null | undefined;
readonly timezone?: unknown;
readonly role?: UserRole | null | undefined;
readonly ageRange1?: Array<number | null | undefined> | null | undefined;
readonly ageRange2: Array<number | null | undefined>;
readonly ageRange3?: Array<number> | null | undefined;
readonly ageRange4: Array<number>;
readonly ageRange1?: ReadonlyArray<number | null | undefined> | null | undefined;
readonly ageRange2: ReadonlyArray<number | null | undefined>;
readonly ageRange3?: ReadonlyArray<number> | null | undefined;
readonly ageRange4: ReadonlyArray<number>;
readonly bestFriend?: UsersBestFriendInput | null | undefined;
readonly nestedInput?: UsersInput | null | undefined;
};
Expand Down
Loading