Fix ESM issue for CLI require flag on Windows#10861
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5312bea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://pr-10861.graphql-code-generator.pages.dev |
eddeee888
force-pushed
the
fix-esm-cli-on-windows
branch
from
29cc54f to
6683f15
Compare
eddeee888
force-pushed
the
fix-esm-cli-on-windows
branch
2 times, most recently
from
432f763 to
675991e
Compare
eddeee888
force-pushed
the
fix-esm-cli-on-windows
branch
from
675991e to
f797577
Compare
eddeee888
changed the title
require flag on Windows
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes importing modules from CLI
requireflag for ESM on native Windows.When the
requireflag is used, a module is resolved with native path e.g.C:\\Users\\path\\to\\file.ts. This is not usable inimport()(dynamic import) in ESM.To solve this for ESM, we need to use
url.pathToFileURLon the filename, which converts the value with the correct protocolfile:///and pathC:/Users/path/to/file.ts.CJS works fine with
import()Related #10842
Type of change
How Has This Been Tested?
dev-test(integration)