This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Open
Conversation
- Made all properties DependencyProperties to monitor property changes - Hooked various control lifecycle stages to attempt WebView startup
Contributor
Author
|
Oops @SteveSandersonMS I forgot to tag you on this! 😁 If you could take a quick look for a sanity check, I will re-apply these changes to the big PR in the ASP.NET Core repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on some conversations with WPF experts and much analysis. I've tried several alternatives and nothing else seemed to work. Based on docs, using a ControlTemplate seems like a reasonable approach. It does mean that developers could try to much with implementation details of this control, but I consider that to simply be "not supported" if they do something wacky.
There are still unresolved issues around the following: