Revert "[Android] Fix status bar icon contrast with custom colorPrimary" (#36214) - #37719
Draft
sheiksyedm with Copilot wants to merge 1 commit into
Draft
Revert "[Android] Fix status bar icon contrast with custom colorPrimary" (#36214)#37719sheiksyedm with Copilot wants to merge 1 commit into
sheiksyedm with Copilot wants to merge 1 commit into
Conversation
Co-authored-by: sheiksyedm <23059975+sheiksyedm@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
sheiksyedm
August 21, 2026 13:51
View session
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This reverts #36214 ("[Android] Fix status bar icon contrast with custom colorPrimary").
That PR changed
ConfigureTranslucentSystemBarsinsrc/Core/src/Platform/Android/WindowExtensions.csto resolve the effectivecolorPrimaryfrom the current Android theme and use its luminance to decide status bar icon appearance, instead of relying solely on the app's light/dark theme.This PR reverts
WindowExtensions.csto its pre-#36214 state, restoring the original theme-based logic forAppearanceLightStatusBars/AppearanceLightNavigationBarsand removing theTryGetThemeColor/IsLightColorhelper methods and relatedAndroidX.Core.Graphics/AColorusings.Issues Fixed
Reverts #36214