[WIP]Fix BackButtonBehavior.Command CanExecuteChanged memory leak - #37771
Draft
devanathan-vaithiyanathan wants to merge 2 commits into
Draft
[WIP]Fix BackButtonBehavior.Command CanExecuteChanged memory leak#37771devanathan-vaithiyanathan wants to merge 2 commits into
devanathan-vaithiyanathan wants to merge 2 commits into
Conversation
devanathan-vaithiyanathan
temporarily deployed
to
copilot-pat-pool
August 24, 2026 10:01 — with
GitHub Actions
Inactive
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 37771Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 37771" |
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
devanathan-vaithiyanathan
temporarily deployed
to
copilot-pat-pool
August 24, 2026 10:01 — with
GitHub Actions
Inactive
devanathan-vaithiyanathan
temporarily deployed
to
copilot-pat-pool
August 24, 2026 10:02 — with
GitHub Actions
Inactive
devanathan-vaithiyanathan
temporarily deployed
to
copilot-pat-pool
August 24, 2026 10:04 — with
GitHub Actions
Inactive
devanathan-vaithiyanathan
temporarily deployed
to
copilot-pat-pool
August 24, 2026 10:06 — with
GitHub Actions
Inactive
devanathan-vaithiyanathan
temporarily deployed
to
copilot-pat-pool
August 24, 2026 10:06 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Details
BackButtonBehavior.Command strongly subscribed to CanExecuteChanged, causing discarded behaviors and their binding contexts to remain in memory.
Description of Change
Updated BackButtonBehavior.Command to use WeakCommandSubscription for CanExecuteChanged. The previous subscription is disposed when the command changes, preventing long-lived commands from retaining discarded behaviors and their binding contexts.
Issues Fixed
Fixes #37635
Tested the behavior in the following platforms.
Before.mov
After.mov