Fix JsonException message property type info in class parameterized constructor#126575
Open
XeronOwO wants to merge 1 commit intodotnet:mainfrom
Open
Fix JsonException message property type info in class parameterized constructor#126575XeronOwO wants to merge 1 commit intodotnet:mainfrom
XeronOwO wants to merge 1 commit intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an incorrect type hint in the thrown
JsonExceptionwhen deserialization fails for classes with parameterized constructors.Reproduction
Expected Output
Actual Output
Root Cause
For classes with parameterized constructors,
state.Current.CtorArgumentState.JsonParameterInfowas used instead ofstate.Current.JsonPropertyInfo.(All structs, including parameterized structs and record structs, work correctly without this issue.)
runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs
Lines 636 to 642 in 3f14c31
As a result, the exception message fell back to
state.Current.JsonTypeInfo.Typefor affected classes.runtime/src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs
Lines 542 to 544 in 3f14c31
Fix
Added logic to retrieve type information from
state.Current.CtorArgumentState.JsonParameterInfo.ParameterType, ensuring correct type resolution for classes with parameterized constructors.