Skip to content

Fix PageSetupDialog margin unit conversion mismatch #14494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeafShi1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix PageSetupDialog margin unit conversion mismatch #14494

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3829ad4
Fix PageSetupDialog margin unit conversion mismatch
LeafShi1 Apr 24, 2026
d61bbdc
Update code following the suggestion
LeafShi1 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/System.Windows.Forms/System/Windows/Forms/Printing/PageSetupDialog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ protected override unsafe bool RunDialog(IntPtr hwndOwner)
fixed (char* pBuffer = buffer)
{
result = PInvoke.GetLocaleInfoEx(
PInvoke.LOCALE_NAME_SYSTEM_DEFAULT,
string.Empty, // empty string == LOCALE_NAME_USER_DEFAULT, matches what the native PageSetupDlg dialog uses
Comment thread
LeafShi1 marked this conversation as resolved.
PInvoke.LOCALE_IMEASURE,
pBuffer,
buffer.Length);
Expand All @@ -299,6 +299,19 @@ protected override unsafe bool RunDialog(IntPtr hwndOwner)
}
Comment thread
LeafShi1 marked this conversation as resolved.
}

// Explicitly pass the unit flag to the native dialog so it operates in the same unit system
// that WinForms used when converting margins above. This ensures that the values written into
// rtMargin/rtMinMargin and the values read back in UpdateSettings are always in the same unit,
// regardless of how system-level and user-level locale settings may differ.
Comment thread
LeafShi1 marked this conversation as resolved.
Outdated
if (toUnit == PrinterUnit.HundredthsOfAMillimeter)
{
dialogSettings.Flags |= PAGESETUPDLG_FLAGS.PSD_INHUNDREDTHSOFMILLIMETERS;
}
else
{
dialogSettings.Flags |= PAGESETUPDLG_FLAGS.PSD_INTHOUSANDTHSOFINCHES;
}
Comment thread
LeafShi1 marked this conversation as resolved.
Outdated

if (MinMargins is not null)
{
Margins margins = PrinterUnitConvert.Convert(MinMargins, PrinterUnit.Display, toUnit);
Expand Down
Loading