-
Notifications
You must be signed in to change notification settings - Fork 1
fix(deps): update rust crate opentelemetry_sdk to 0.32 #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,7 +60,7 @@ tracing = "0.1.41" | |
| tracing-opentelemetry = "0.32.1" | ||
| tracing-subscriber = { version = "0.3.18", features = ["env-filter", "registry"] } | ||
| opentelemetry = "0.31.0" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Blocking: This line pins Why it matters: Types and traits from different major versions of Suggested fix: Update this to |
||
| opentelemetry_sdk = { version = "0.31", features = ["rt-tokio"] } | ||
| opentelemetry_sdk = { version = "0.32", features = ["rt-tokio"] } | ||
| opentelemetry-otlp = { version = "0.31", default-features = false, features = ["http-proto", "reqwest-blocking-client", "reqwest-rustls"] } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Blocking: This version ( Why it matters: The Suggested fix: Update to |
||
| url = { version = "2.5", features = ["serde"] } | ||
| bon = "3.6.5" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: This version (
0.32.1) depends onopentelemetry 0.31.x, but you're updatingopentelemetry_sdkto0.32which requiresopentelemetry 0.32.x. Per docs.rs,tracing-opentelemetry 0.33.0depends onopentelemetry ^0.32.0.Why it matters: Keeping this at 0.32.1 while updating
opentelemetry_sdkto 0.32 contributes to the dual-version problem where bothopentelemetry 0.31andopentelemetry 0.32end up in the dependency tree.Suggested fix: Update to
tracing-opentelemetry = "0.33"to align with theopentelemetry 0.32ecosystem.