Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 49 additions & 19 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ tracing = "0.1.41"
tracing-opentelemetry = "0.32.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: This version (0.32.1) depends on opentelemetry 0.31.x, but you're updating opentelemetry_sdk to 0.32 which requires opentelemetry 0.32.x. Per docs.rs, tracing-opentelemetry 0.33.0 depends on opentelemetry ^0.32.0.

Why it matters: Keeping this at 0.32.1 while updating opentelemetry_sdk to 0.32 contributes to the dual-version problem where both opentelemetry 0.31 and opentelemetry 0.32 end up in the dependency tree.

Suggested fix: Update to tracing-opentelemetry = "0.33" to align with the opentelemetry 0.32 ecosystem.

tracing-subscriber = { version = "0.3.18", features = ["env-filter", "registry"] }
opentelemetry = "0.31.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: This line pins opentelemetry to version 0.31.0, but opentelemetry_sdk 0.32 (updated on line 63) depends on opentelemetry ^0.32. This creates a dependency version conflict where Cargo will pull in BOTH opentelemetry 0.31.0 AND opentelemetry 0.32.0 simultaneously.

Why it matters: Types and traits from different major versions of opentelemetry are NOT compatible. The code in src/telemetry.rs uses opentelemetry::trace::TracerProvider alongside opentelemetry_sdk::trace::SdkTracerProvider, which can lead to type mismatches and compilation errors.

Suggested fix: Update this to opentelemetry = "0.32" to match the opentelemetry_sdk version, and also update tracing-opentelemetry to 0.33 and opentelemetry-otlp to 0.32 for consistency.

opentelemetry_sdk = { version = "0.31", features = ["rt-tokio"] }
opentelemetry_sdk = { version = "0.32", features = ["rt-tokio"] }
opentelemetry-otlp = { version = "0.31", default-features = false, features = ["http-proto", "reqwest-blocking-client", "reqwest-rustls"] }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: This version (0.31) depends on opentelemetry 0.31.x and opentelemetry_sdk 0.31.x, creating another source of version conflict when opentelemetry_sdk is updated to 0.32.

Why it matters: The src/telemetry.rs file uses opentelemetry_otlp::{Protocol, WithExportConfig, WithHttpConfig} to build the OTLP exporter. Having mismatched versions between opentelemetry-otlp and opentelemetry_sdk can cause API incompatibilities.

Suggested fix: Update to opentelemetry-otlp = { version = "0.32", default-features = false, features = ["http-proto", "reqwest-blocking-client", "reqwest-rustls"] }. Verify that the feature flags remain valid in version 0.32.

url = { version = "2.5", features = ["serde"] }
bon = "3.6.5"
Expand Down
Loading