This repository was archived by the owner on Dec 31, 2019. It is now read-only.
deprecate in favour of https://github.com/istanbuljs/babel-plugin-istanbul#122
Open
graingert wants to merge 1 commit intodouglasduteil:masterfrom
Open
deprecate in favour of https://github.com/istanbuljs/babel-plugin-istanbul#122graingert wants to merge 1 commit intodouglasduteil:masterfrom
graingert wants to merge 1 commit intodouglasduteil:masterfrom
Conversation
Author
|
@douglasduteil please for the sake of your users, kill this package. |
|
This PR looks more like it's nuking everything rather than "deprecating" the package. The appropriate thing to do is leave a message in the README.md and version lock |
Author
|
Sure but removing the code doesn't change anything about the npm package, just reduces the ranking in Google |
|
Adding a deprecation warning at the top of the README should be more than sufficient for directing users to a better solution. Removing the code provides no benefit and is only going to hurt those who are interesting in learning how this package works (or perhaps used to work). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.