Skip to content

Return errors instead of logging/go modules/comments#12

Open
KatamariJr wants to merge 3 commits intodpapathanasiou:masterfrom
KatamariJr:master
Open

Return errors instead of logging/go modules/comments#12
KatamariJr wants to merge 3 commits intodpapathanasiou:masterfrom
KatamariJr:master

Conversation

@KatamariJr
Copy link
Copy Markdown

@KatamariJr KatamariJr commented Dec 6, 2019

  • Added go.mod file to support modules.
  • It is more useful to return the errors rather than logging them, whatever code calls this library would be the one that should actually handle logging, and it makes more sense to wrap that error that gets returned instead.
  • Cleaned up the comments, as they seemed to be outdated/not written as well as they could be.

Also, if you merge this, you should tag it as v1.0.0

Austin Green added 3 commits December 6, 2019 17:05
-cleaned up comments to make more sense
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant