Skip to content

fix(@dpc-sdp/ripple-ui-core): vertical nav indentation#1409

Merged
lambry merged 3 commits into
mainfrom
feature/vertical-nav-indent
Jun 11, 2026
Merged

fix(@dpc-sdp/ripple-ui-core): vertical nav indentation#1409
lambry merged 3 commits into
mainfrom
feature/vertical-nav-indent

Conversation

@lambry

@lambry lambry commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Issue: https://digital-vic.atlassian.net/browse/SD-1774

What I did

  • Update vertical nav indents, some menu items show as 'sub/indented' items even when they aren't

How to test

Reference menu: https://develop.content-vic.sdp.delivery/admin/structure/menu/manage/site-main-menu-vicgovau-protect
Current: https://develop.vic-gov-au.sdp.delivery/develop-school-child-safety-and-wellbeing-policy
Updated: https://app.pr-1383.vic-gov-au.sdp4.sdp.vic.gov.au/develop-school-child-safety-and-wellbeing-policy

Screenshot 2026-06-09 at 4 57 59 pm

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Jun 9, 2026
@lambry lambry requested review from a team, dylankelly and jeffdowdle June 9, 2026 07:33
@lambry lambry requested a review from waitingallday June 11, 2026 05:37
@lambry lambry merged commit d3c0573 into main Jun 11, 2026
10 of 11 checks passed
@lambry lambry deleted the feature/vertical-nav-indent branch June 11, 2026 22:52
@github-actions github-actions Bot mentioned this pull request Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants