fix: switch from uuid1 to uuid4 for better randomness#2435
Open
RinZ27 wants to merge 1 commit into
Open
Conversation
RinZ27
force-pushed
the
fix/predictable-hashes-uuid4
branch
from
66b8200 to
5770914
Compare
RinZ27
force-pushed
the
fix/predictable-hashes-uuid4
branch
from
5770914 to
2deb2a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switching from
uuid.uuid1()touuid.uuid4()for generating registration hashes and unique filenames ensures better randomness. Since UUID1 is generated using the host's MAC address and current time, it can be somewhat predictable in certain environments. Moving to UUID4 eliminates this predictability, which is a security best practice for generating sensitive tokens like account activation hashes. This change improves the overall robustness of the user registration process.ADDITIONAL INFORMATION