metric: treat io.EOF as successful upload, not an error#2004
Open
lushenle wants to merge 1 commit intodrakkan:mainfrom
Open
metric: treat io.EOF as successful upload, not an error#2004lushenle wants to merge 1 commit intodrakkan:mainfrom
lushenle wants to merge 1 commit intodrakkan:mainfrom
Conversation
Uploads that end with io.EOF are now considered successful and no longer increment the upload error metric. This aligns metric reporting with Go convention, where io.EOF indicates normal completion rather than an error.
|
lushenle seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Owner
|
If an upload returns EOF, you will have a partial file or no file at all, depending on the storage backend and the SFTPGo configuration |
f2c3eb6 to
a2d3613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
internal/metric/metric.gofile, focusing on error handling and dependency updates. The changes improve the robustness of metrics tracking by accounting for additional error scenarios and updating imports.Error handling improvements:
TransferCompletedfunction to incrementtotalUploadseven when the error isio.EOF, ensuring proper metrics tracking for completed transfers despite this specific error condition.Dependency updates:
errorsandiopackages to support the new error handling logic in theTransferCompletedfunction.Uploads that end with io.EOF are now considered successful and no longer increment the upload error metric. This aligns metric reporting with Go convention, where io.EOF indicates normal completion rather than an error.Checklist for Pull Requests